Resolved some code review findings
This commit is contained in:
parent
7bcbbdb5ce
commit
3d78f7c825
@ -92,5 +92,5 @@ The project also includes custom MSBuild targets (`IncludeProjectReferencesWithP
|
|||||||
## Contributing
|
## Contributing
|
||||||
|
|
||||||
Please refer to the contribution guidelines of the Rms.Risk.Mango project if you wish to contribute.
|
Please refer to the contribution guidelines of the Rms.Risk.Mango project if you wish to contribute.
|
||||||
Drop a email to mailto:forge@list.db.com.
|
|
||||||
|
|
||||||
|
|||||||
@ -208,10 +208,6 @@
|
|||||||
SelectedJob = RunningJobs[0];
|
SelectedJob = RunningJobs[0];
|
||||||
|
|
||||||
_ = Task.Run(() => RefreshLoop(_cts.Token), _cts.Token);
|
_ = Task.Run(() => RefreshLoop(_cts.Token), _cts.Token);
|
||||||
|
|
||||||
// #if DEBUG
|
|
||||||
// await PrepareCollectionNames("C:\\shabale\\Downloads\\dbMango_data.zip");
|
|
||||||
// #endif
|
|
||||||
}
|
}
|
||||||
catch (Exception ex)
|
catch (Exception ex)
|
||||||
{
|
{
|
||||||
|
|||||||
@ -427,8 +427,8 @@
|
|||||||
private string StageWhere =
|
private string StageWhere =
|
||||||
@"
|
@"
|
||||||
WHERE
|
WHERE
|
||||||
( cob == ""2025-04-22"" && Department == ""FX Options"" )
|
( cob == ""2025-04-22"" && Department == ""Department Name"" )
|
||||||
&& Book NOT IN (""CHFX"", ""JPYPJPY"")
|
&& Book NOT IN (""Book1"", ""Book2"")
|
||||||
|
|
||||||
";
|
";
|
||||||
|
|
||||||
@ -543,7 +543,7 @@ FACET
|
|||||||
@"
|
@"
|
||||||
WHERE
|
WHERE
|
||||||
COB == date( ""2025-05-15T00:00:00Z"" )
|
COB == date( ""2025-05-15T00:00:00Z"" )
|
||||||
AND (Department == ""FX Options Controlling"" )
|
AND (Department == ""Department Name"" )
|
||||||
WHERE
|
WHERE
|
||||||
$VegaDetails.VegaImpact == exists( true )
|
$VegaDetails.VegaImpact == exists( true )
|
||||||
PROJECT
|
PROJECT
|
||||||
|
|||||||
@ -109,7 +109,7 @@
|
|||||||
|
|
||||||
private readonly List<GroupedCollection> _collections = [];
|
private readonly List<GroupedCollection> _collections = [];
|
||||||
|
|
||||||
private const string DefaultCollectionName = "Forge: PnL";
|
private const string DefaultCollectionName = "Default";
|
||||||
private const string DefaultPivotName = "Summary";
|
private const string DefaultPivotName = "Summary";
|
||||||
|
|
||||||
private ExtraFilterDefinition _extraFilterDef = new();
|
private ExtraFilterDefinition _extraFilterDef = new();
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user